Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blitting code refactor #87

Open
boberfly opened this issue Mar 12, 2021 · 0 comments
Open

Blitting code refactor #87

boberfly opened this issue Mar 12, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@boberfly
Copy link
Contributor

Thought I'd log it here as an issue:

The current blitting code has a few issues, notably it looks as though there are too many branch checks at the pixel-level where we could refactor the branches at the whole image/tile level and win back performance, as these checks are mostly for determining conversion to/from types that don't change per-pixel on an image.
https://github.com/tangent-opensource/hdcycles/blob/main/plugin/hdCycles/renderBuffer.cpp#L32

The other issue is that currently I think single channel buffers are not blitting right, this is a screenshot of the depth pass at the screen edge (using BlitTile function):
Screenshot_20210311_162215

Cheers

@bareya bareya added this to Needs triage in HdCycles Development Mar 23, 2021
@dedoardo dedoardo added the bug Something isn't working label Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants