Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent curve basis handling #65

Open
Vochsel opened this issue Feb 5, 2021 · 1 comment
Open

Inconsistent curve basis handling #65

Vochsel opened this issue Feb 5, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Vochsel
Copy link
Contributor

Vochsel commented Feb 5, 2021

We currently don't properly handle curves of different types, wraps properly

https://graphics.pixar.com/usd/docs/api/class_usd_geom_basis_curves.html#details

@Vochsel Vochsel added this to the 0.9.0 milestone Feb 5, 2021
@bareya bareya modified the milestones: 0.9.0, 0.9.1 Mar 9, 2021
@bareya bareya added this to High priority in HdCycles Development Mar 23, 2021
@bareya bareya added the bug Something isn't working label Mar 23, 2021
@bareya bareya modified the milestones: 0.9.1, 0.9.2 Mar 23, 2021
@dedoardo dedoardo self-assigned this Mar 23, 2021
@dedoardo
Copy link
Contributor

From a read through the code I noticed the following issues:

  • We currently rely on the cycles tokens to distinguish whether a curve is a cylinder or flat. The usd specification states that it is something that should be deduced from the presence of widths or not. We should have both options.
  • The wrap mode of curves seems to be ignored (same goes for basis/type).
  • I read that for cubic curves to linearly interpolate a primvar you use 'Varying' but in the code I see 'Vertex'
  • I miss the context for the older curves (closing cylinders as tubes?). I wonder if we still need it...

In general I think the code could use being revisited, possibly with a simple test scene containing all possible combinations of inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

3 participants