Always set default values at the start of a sync #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boberfly
requested review from
bareya,
dedoardo,
sergeneren,
skwerner and
Vochsel
as code owners
bareya
reviewed
Apr 23, 2021
plugin/hdCycles/basisCurves.cpp
Outdated
| @@ -409,6 +409,13 @@ HdCyclesBasisCurves::Sync(HdSceneDelegate* sceneDelegate, HdRenderParam* renderP | |||
| bool generate_new_curve = false; | |||
| bool update_curve = false; | |||
|
|
|||
| // Defaults | |||
| m_visCamera = m_visDiffuse = m_visGlossy = m_visScatter = m_visShadow = m_visTransmission = true; | |||
| m_useMotionBlur = true; | |||
There was a problem hiding this comment.
Why motion blur is enabled by default?
There was a problem hiding this comment.
As we mentioned in our chat, I was only setting to true because your other patch will be defaulting it to true. I'm happy to make it false.
There was a problem hiding this comment.
I mentioned that my patch will not be defaulting it to true on object level, but on integrator level.
There was a problem hiding this comment.
Changed to false now
…nothing" is set in Solaris, or a different node is picked, it'll start back with sane defaults. This addresses curves, lights, meshes and volumes. TODO: All global values in renderParam need the defaults set on any scene refresh also.
boberfly
force-pushed
the
fix/default_fallback
branch
from
7c7b15b
to
cb2980a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always set default values at the start of a sync, so that when a "do nothing" is set in Solaris, or a different node is picked, it'll start back with sane defaults. This addresses curves, lights, meshes and volumes.
TODO: All global values in renderParam need the defaults set on any scene refresh also, but for now we can just be explicit with our RenderSettings node (seems like no other delegate works correctly here as well, including PRMan).
And as an extra note, we may need to be vigilant on any new schema that gets added here. We can also use the cycles node API to set built-in defaults if we prefer also, but lets do that once we upgrade to the latest cycles API just in case they have a new/different way now.