GUI: Image is not updated when switching videos

[roomrys]

Bug description

⚠️ Only present on the multiview branch. Only present if on last frame of video when switching videos.

Argh! It was a video encoding problem with the MV test videos.

The callback for the "video" state loads the new video image at this line (but this does not happen when switching videos on the last frame prior to updating the "video" state).

sleap/sleap/gui/widgets/video.py

Line 172 in 0134ab4

self.load_queue.append(frame_idx)

This is a regression. In the past, the image would update when selecting a new video in the GUI.

Currently, users need to change frames after selecting a video to update the plotted image. This is also noticeable in start-up of the GUI where the default background image remains present even if a video is loaded.

Initial frame loaded correctly, but then when switching to a new video, the plot is not updated:

Expected behaviour

After selecting a video, the plotted image should automatically update.

Actual behaviour

The image only updates when selecting a new frame in the seekbar/arrow keys.

Your personal set up

• OS: mac 13.4

• Version(s): 1.3.3, python 3.9

• SLEAP installation method (listed here):
  • Conda from package
  • Conda from source
  • pip package

[roomrys]

Trace

On initialization, the QtVideoPlayer connects the "video" state to a callback

sleap/sleap/gui/widgets/video.py

Line 278 in 6b14bca

self.state.connect("video", self.load_video)

more specifically, the QtVideoPlayer.load_video function

sleap/sleap/gui/widgets/video.py

Line 398 in 6b14bca

def load_video(self, video: Video, plot=True):

which calls QtVideoPlayer.plot

sleap/sleap/gui/widgets/video.py

Line 480 in 6b14bca

def plot(self, *args):

which uses an image loader to set the image once loaded

sleap/sleap/gui/widgets/video.py

Lines 260 to 263 in 6b14bca

	# Connect signal so that image will be shown after it's loaded
	self._video_image_loader.result.connect(
	lambda qimage: self.view.setImage(qimage)
	)

Is the video state being updated when we switch video's? After a video that is missing is found?

The VideosDock.table attribute has has a function activateSelected which will change the state["video"] if table.is_activatable

sleap/sleap/gui/dataviews.py

Lines 340 to 347 in 1e0627a

	def activateSelected(self, *args):
	"""Activate item currently selected in table.
	"Activate" means that the relevant :py:class:`GuiState` state variable
	is set to the currently selected item.
	"""
	if self.is_activatable:
	self.state[self.row_name] = self.getSelectedRowItem()

(and assuming table.row_name == "video" - which is true)

sleap/sleap/gui/widgets/docks.py

Line 179 in 1e0627a

row_name="video",

we call activateSelected when a row item is double clicked

sleap/sleap/gui/dataviews.py

Line 328 in 1e0627a

self.doubleClicked.connect(self.activateSelected)

[roomrys]

Fixed with #1787