Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs - Vue: Computed is still dirty #3001

Closed
eos-alexri opened this issue Feb 20, 2024 · 1 comment
Closed

Tabs - Vue: Computed is still dirty #3001

eos-alexri opened this issue Feb 20, 2024 · 1 comment
Assignees

Comments

@eos-alexri
Copy link

What package within Headless UI are you using?

@headlessui/vue

What version of that package are you using?

v1.7.19

What browser are you using?

Chrome

Reproduction URL

https://stackblitz.com/edit/vitejs-vite-5cd8u1?file=src%2FApp.vue

Have a look at the console to see the warning.

Describe your issue

After updating our project to vue@3.4.19, I have noticed that the tabs are causing following warning:

[Vue warn] Computed is still dirty after getter evaluation, likely because a computed is mutating its own dependency in its getter. State mutations in computed getters should be avoided.  Check the docs for more details: https://vuejs.org/guide/essentials/computed.html#getters-should-be-side-effect-free
@reinink
Copy link
Member

reinink commented Feb 20, 2024

Hey! Thanks for reporting this, but it looks like a duplicate of #2985, so I'm going to close this in favor of that one 👍

@reinink reinink closed this as completed Feb 20, 2024
@reinink reinink self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants