Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Update k8s-operator custom image configuration for Renovate compatibility #12100

Open
Yeradon opened this issue May 11, 2024 · 1 comment
Labels
fr Feature request good first issue Good for newcomers kubernetes needs-triage

Comments

@Yeradon
Copy link

Yeradon commented May 11, 2024

What are you trying to do?

I'm addressing an issue where the default helm-values manager of Renovate fails to recognize the custom image options in the k8s-operator chart's values file. It expects repository, but it's repo in this chart (docs).

How should we solve this?

Renaming is a simple but breaking change. A backward-compatible option would be supporting both names, but it adds unnecessary complexity.

What is the impact of not solving this?

Currently, using Renovate with this chart requires a custom manager, detailed here. This needs to be done for each Renovate instance supporting this chart.

@Yeradon Yeradon added fr Feature request needs-triage labels May 11, 2024
@Yeradon Yeradon changed the title FR: Update custom operator image configuration for Renovate compatibility FR: Update k8s-operator custom image configuration for Renovate compatibility May 11, 2024
@irbekrm
Copy link
Contributor

irbekrm commented May 13, 2024

A backward-compatible option would be supporting both names, but it adds unnecessary complexity

We should not break existing users. If this can be done in a backwards compatible manner, happy for this to be added. Helm syntax should support picking one of two values for a template field, depening on which is set if any.

@irbekrm irbekrm added kubernetes good first issue Good for newcomers labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fr Feature request good first issue Good for newcomers kubernetes needs-triage
Projects
None yet
Development

No branches or pull requests

2 participants