Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove println in the code #80

Open
michellemay opened this issue Oct 17, 2018 · 2 comments
Open

Remove println in the code #80

michellemay opened this issue Oct 17, 2018 · 2 comments

Comments

@michellemay
Copy link

When running GPRegression model, I find that it is particularly verbose in the console. At first, I thought it was log4j configuration being too verbose. However, grepping in the code, I can see lots of println.

I suggest replacing these println with logger debug or trace level.

@mandar2812
Copy link
Member

Hi @michellemay, Yes indeed they are mostly pprint.pprintln() statements from ammonite which I inserted. I wanted colour coding of the console logs but it was not possible in log4j.

I guess one way to deal with this is to set some config variable which will avoid executing the println() statements.

Or unless you know of a way to get colour coded console logs?

@michellemay
Copy link
Author

I'm not sure about all the other uses, but in AbstractGPRegressionModel, it's regular println("\nGaussian Process Regression")

And to answer your question, I'm not familiar with ammonite at all! I just discovered it exists and plan on using it.

mandar2812 added a commit that referenced this issue Aug 9, 2019
  -- Added progress bar
  -- Removing unnecessary print statements #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants