Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated Approve asset spend during swapping #3656

Open
michalinacienciala opened this issue Nov 6, 2023 · 0 comments
Open

Duplicated Approve asset spend during swapping #3656

michalinacienciala opened this issue Nov 6, 2023 · 0 comments
Labels
Type: Bug Something isn't working

Comments

@michalinacienciala
Copy link
Contributor

Quite often when doing a swap of a token that does not have a spending approval yet set I'm hitting a case where the token approval transaction is displayed for the second time in a row after I already approved the spending (before I did the actual swap).
This is how making a swap looks like in such case:

Screen.Recording.2023-11-06.at.16.20.59.mov

The behavior is not 100% consistent, there were cases where there was only one token approval transaction. To reproduce I would advise to do swaps on couple of different networks. The networks which I saw a problem on: Ethereum, Polygon, BNB. Some time ago Andrea saw this on Ethereum and Optimism.

The wallet I tested on: extension-builds-3652

@michalinacienciala michalinacienciala added the Type: Bug Something isn't working label Nov 6, 2023
This was referenced Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant