Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSP-5] We need some stringification methods that produce spec-compliant SQL strings from a parsed statement/AST #41

Open
carsonfarmer opened this issue Dec 13, 2022 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request linear Sync issue with linear

Comments

@carsonfarmer
Copy link
Member

carsonfarmer commented Dec 13, 2022

Currently, if you parse a statement (create) on the client side using our parser and/or the WASM wrapper, you'll get back a normalized string that is intended to be consumed by the SQLite backend. It is not spec compliant, in that in may contain AUTOINCREMENT, STRICT, and other non-compliant SQL elements. These are implementations details. Ideally, we'd have a "spec safe" string method on the AST that would produce a parsed output that could be parsed again safely by the parser. This would make using the parser on the client side much easier, useful, and safe.

GSP-5

@carsonfarmer carsonfarmer added bug Something isn't working enhancement New feature or request labels Dec 13, 2022
@brunocalza brunocalza added the linear Sync issue with linear label Mar 23, 2023
@brunocalza brunocalza changed the title We need some stringification methods that produce spec-compliant SQL strings from a parsed statement/AST [GSP-5] We need some stringification methods that produce spec-compliant SQL strings from a parsed statement/AST Mar 23, 2023
@sanderpick
Copy link
Member

@carson is this issue still a thing? (i'm trying to clean up triage issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request linear Sync issue with linear
Projects
None yet
Development

No branches or pull requests

3 participants