Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for CommonJS #104

Open
NiclasThobaben opened this issue Feb 23, 2023 · 4 comments
Open

Support for CommonJS #104

NiclasThobaben opened this issue Feb 23, 2023 · 4 comments

Comments

@NiclasThobaben
Copy link

Hi,
do you plan on supporting a commonJS build of the library or will it stay pure ESM?
@rwieruch
Copy link
Contributor

rwieruch commented Mar 5, 2023

I didn't plan to support it. Can't you use ESM in your project?

@NiclasThobaben
Copy link
Author

We do. However, we use some tools, like Jest, which rely on CommonJS. For Jest this is not a huge problem, as it support transformation of dependencies, before execution, but other tools (i.e. cucumber-js) have issues with that.

@rwieruch
Copy link
Contributor

If this is an easy change, feel free to open a PR :)

@Audiopolis
Copy link

It should just be this, no?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwieruch @Audiopolis @NiclasThobaben