Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to use Geist Sans instead of Inter #1821

Merged
merged 11 commits into from May 7, 2024

Conversation

kakeWasTaken
Copy link
Contributor

Closes #1683

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Added the option in the CLI to create a project with Geist Sans as the default font instead of Inter.


Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: d37302a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 1 resolved
May 7, 2024 8:31pm

Copy link

vercel bot commented Apr 11, 2024

@kakeWasTaken is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, thanks for filing a pull request to this project! Highly appreciate it.

I think we should just change the default to be Geist and not provide an option in the CLI. Want to keep the number of prompts to a minimum.

WDYT @c-ehrlich ?

@nexxeln
Copy link
Member

nexxeln commented Apr 24, 2024

why do we need geist as default? it's one extra package which needs to be installed and people who don't want to use geist need to then uninstall a package to change the font. i personally think inter is a great default

@kakeWasTaken
Copy link
Contributor Author

Hey, I removed the option to choose a font and set Geist to be the default font instead.

Let me know if I should change anything else.

@juliusmarminge
Copy link
Member

can you update the PR - there's a lot of diff and seems like you're a couple commits behind main

Ethan Zhou and others added 2 commits May 2, 2024 10:25
# Conflicts:
#	cli/package.json
#	package.json
#	pnpm-lock.yaml
Copy link
Contributor Author

@kakeWasTaken kakeWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set default font to Geist Sans instead of Inter
Updated to the latest version of create-t3-app

cli/package.json Outdated Show resolved Hide resolved
cli/src/cli/index.ts Outdated Show resolved Hide resolved
cli/src/installers/dependencyVersionMap.ts Outdated Show resolved Hide resolved
cli/src/installers/geist.ts Outdated Show resolved Hide resolved
cli/template/base/next.config.js Show resolved Hide resolved
@juliusmarminge
Copy link
Member

Linter fails

@juliusmarminge juliusmarminge added this pull request to the merge queue May 7, 2024
Merged via the queue into t3-oss:main with commit 4de1927 May 7, 2024
265 of 266 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Giest instead of Inter
3 participants