New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When used in iframe, mouseup outside viewport is not detected #702
Comments
I think a better fix would be to end the line on move if the button isn't pressed. That would fix mouseup outside the browser as well. |
@UziTech that could work, but I have a concern. Your solution would not trigger the |
We should probably do both, fire endStroke on window.mouseup or window.mousemove if mouseup was never called. My only concern with using |
I created a POC of how I think the event listeners should change in #703. I listen for I also added |
same i can not use with DPI check when i use php include :( |
this should be fixed in v5 |
If you have a question, please ask it on StackOverflow and use
signature-pad
tag instead of creating an issue.Do you want to request a feature or report a bug?
Bug
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/szimek/h80phxyr/).
What is the expected behavior?
When the user mouses up, the drawing stops even if the mouseup was outside the viewport.
window.addEventListener('mouseup') can detect a mouseup outside the viewport as long as the mousedown was inside the viewport, which is the case we want to detect. Not sure how a
touchend` works in this case or if there are any touchscreen considerations.Which versions of SignaturePad, and which browser / device are affected by this issue? Did this work in previous versions of SignaturePad?
Chromium 110, signature_pad version 4.1.5
The text was updated successfully, but these errors were encountered: