Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintained? #465

Closed
Sparticuz opened this issue Dec 4, 2019 · 7 comments
Closed

Maintained? #465

Sparticuz opened this issue Dec 4, 2019 · 7 comments

Comments

@Sparticuz
Copy link

Is this project maintained? If not, are there any good alternatives?

@szimek
Copy link
Owner

szimek commented Dec 4, 2019

I don't really have time to maintain it anymore, but I hope to merge a few PRs, update a few dependencies (e.g. TypeScript) and release final 3.0 till mid of January.

@abraxxa
Copy link

abraxxa commented Mar 15, 2020

Seems the mid January release didn' t work out.
Is there anything we can do to help?
My main issue is the incorrect save/load on HiDPI screens.

@szimek
Copy link
Owner

szimek commented Mar 15, 2020

@abraxxa Could you please aggregate all issues and PRs regarding your issue here? It would be great if it was also described how to replicate it. This way there's much higher chance that I'll find time to work on it...

@abraxxa
Copy link

abraxxa commented Mar 15, 2020

The issue is described in #453, the pull-request which should fix it is in #411.

@szimek
Copy link
Owner

szimek commented Mar 15, 2020

@abraxxa Thanks! I'll read a bit about SVG sizing again, because I don't remember how it all works and there's a bunch of places where height and width are set, e.g.

const minX = 0;
const minY = 0;
const maxX = this.canvas.width / ratio;
const maxY = this.canvas.height / ratio;
...
svg.setAttribute('width', this.canvas.width.toString());
svg.setAttribute('height', this.canvas.height.toString());
...
const header =
  '<svg' +
  ...
  ` viewBox="${minX} ${minY} ${maxX} ${maxY}"` +
  ` width="${maxX}"` +
  ` height="${maxY}"` +
  '>';

@abraxxa
Copy link

abraxxa commented Mar 15, 2020

Thanks!

@szimek
Copy link
Owner

szimek commented Mar 22, 2020

@abraxxa @gimyboya I moved the discussion about the SVG issue to #453.

@UziTech UziTech closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants