Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Dt estimation #8

Open
szaghi opened this issue Mar 29, 2017 · 0 comments
Open

Bug in Dt estimation #8

szaghi opened this issue Mar 29, 2017 · 0 comments
Assignees
Labels

Comments

@szaghi
Copy link
Owner

szaghi commented Mar 29, 2017

The algorithm for estimating the time step Dt is bugged, see https://github.com/szaghi/OFF/blob/testing/src/Data_Type_SBlock.f90#L1300

The speed of sound is not multiplied for the interface area thus the vmax is underestimated. Corrected computation should be something like

        ! computing the local speed of sound
        ss = a(p=block%C(i,j,k)%P%p,r=block%C(i,j,k)%P%d,g=block%C(i,j,k)%P%g)
        ! evaluating the maximum propagation speed of acoustic segnals multiplied for face area
        ! left i
        vm   = 0.5_R_P*(block%C(i-1,j,k)%P%v+block%C(i,j,k)%P%v)
        vmiL = (abs(vm.dot.block%Fi(i-1,j,k)%N) + ss ) * block%Fi(i-1,j,k)%S
@szaghi szaghi self-assigned this Mar 29, 2017
@szaghi szaghi added the bug label Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant