Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the .env variables are missing in docker compose file #234

Open
TissuePowder opened this issue Oct 21, 2023 · 1 comment
Open

Some of the .env variables are missing in docker compose file #234

TissuePowder opened this issue Oct 21, 2023 · 1 comment

Comments

@TissuePowder
Copy link

Microbin's port from docker's internal network wasn't being published to the host at all, even though "${MICROBIN_PORT}:8081" was set clearly in compose file. Then I noticed the MICROBIN_PORT wasn't listed under environment in compose file, so it was just trying to forward an undefined/garbage port to the host. And not just that, I believe a few other variables might be missing as well.

Why do you list each variables separately like that though? It would be better and easier if you just link the .env file in the docker compose file, like this

version: "2"
services:
  microbin:
    image: danielszabo99/microbin:latest
    restart: always
    ports:
      - "${MICROBIN_PORT}:8081"
    env_file:
      - .env
    volumes:
     - /var/local/microbin-data:/app/microbin_data

Note that when using the env file like this, we will no longer need the export keyword in the env file.

@kwiniarski97
Copy link
Contributor

kwiniarski97 commented Oct 31, 2023

Will be fixed by #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants