You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the LogThreadedSourceDriver does not have a generic list of metrics that the child implementation could use like how LogWriter, LogReader, LogThreadedDestDriver have one. This causes some boiler plate on the actual implementation side to do when someone want to be consistent with the other implementation.
Proposed solution
Add the similiar solution as it currently in LogThreadedDestDriver so that the child impementations will only have to use the corresponding functions to increment the generic metrics instead of them handling the registering and unregistering themselves
Additional context
I am proposing to do this as it can decrease such boilerplate like what happened in case of PR#4423
Also I would like to see it in a different PR as this might be quite huge impacting every children of LogThreadedSourceDriver
The text was updated successfully, but these errors were encountered:
Description of the problem
Currently the
LogThreadedSourceDriver
does not have a generic list of metrics that the child implementation could use like howLogWriter
,LogReader
,LogThreadedDestDriver
have one. This causes some boiler plate on the actual implementation side to do when someone want to be consistent with the other implementation.Proposed solution
Add the similiar solution as it currently in LogThreadedDestDriver so that the child impementations will only have to use the corresponding functions to increment the generic metrics instead of them handling the registering and unregistering themselves
Additional context
I am proposing to do this as it can decrease such boilerplate like what happened in case of PR#4423
Also I would like to see it in a different PR as this might be quite huge impacting every children of
LogThreadedSourceDriver
The text was updated successfully, but these errors were encountered: