Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application.properties should be optional #20

Open
altavir opened this issue Jan 12, 2017 · 7 comments
Open

application.properties should be optional #20

altavir opened this issue Jan 12, 2017 · 7 comments

Comments

@altavir
Copy link

altavir commented Jan 12, 2017

Currently, application crashes if this file does not exist, but it is not really used. This file does not make sense for embedded site.

@larixer
Copy link
Member

larixer commented Jan 15, 2017

The fact that application crashes, means this file is used. I really don't get your point, why it doesn't makes sense? This file specifies which Grain version should be used to generate static website.

Do you want to specify Grain version in build.gradle, instead? Is this your point?

@altavir
Copy link
Author

altavir commented Jan 15, 2017

I looked through the code. It only checks if then file exist and then does nothing.

It makes sense if one uses Grain as a static generator with pre-built theme. Since the number of such themes is very low, in my opinion the greatest advantage of Grain is its flexibility and ability to embed. In this case it makes much more sense to define grain version in gradle build or in SiteConfig and not to add additional file and clutter up build configuration.

@larixer
Copy link
Member

larixer commented Jan 16, 2017

@altavir application.properties is used mainly for grainw script, which speeds up Grain startup times compared to gradle. If we remove application.properties we will have to drop grainw too, because we have no reliable way to get desired Grain version from build.gradle.

@altavir
Copy link
Author

altavir commented Jan 16, 2017

does grainw work faster than gradle daemon? If not, it is possible that you should drop it. I don't use it so Idon't know.

@larixer
Copy link
Member

larixer commented Jan 16, 2017

I need to take a look at latest Gradle versions, that come with Gradle daemon, if they work reasonably fast, then grainw can be dropped.

@larixer
Copy link
Member

larixer commented Jan 18, 2017

@altavir Alexander, don't you want to fix this issue yourself and submit Pull Request? I think Gradle with daemon will be almost as fast as grainw, could you check and if it is so - then drop 'application.properties' validation and grainw and update gradle wrapper to the latest version. Since you are raising issues for Grain pretty actively, I think it would be nice if you start contributing fixes, of course if you are interested and have time to do so.

@altavir
Copy link
Author

altavir commented Jan 18, 2017

I am definitely interested because I think that Grain is a very promising way to handle static site generation in a very flexible way (flexibility is a key word). I am currently maintaining two sites made with Grain.
As for time, this is much more difficult, but I still will try to do something about it when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants