Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs won't close on Escape key #9489

Open
bugith opened this issue Apr 1, 2024 · 0 comments
Open

Dialogs won't close on Escape key #9489

bugith opened this issue Apr 1, 2024 · 0 comments
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) ui Issues related to the graphical user interface

Comments

@bugith
Copy link

bugith commented Apr 1, 2024

What happened?

Some dialogs don’t close on the same action. Namely all dialogs close always OK on click-outside, but never close none of them on Esc key once another tab is selected, unless we click anywhere in it before (that is, an other way to say the same : Escape key works everywhere but just after we select another tab in dialogs). It is like the dialog looses focus on opening new tab. Although this focus loose seems to affect the Esc key only because then hitting Tab rises the focus to the next object (input field, link image…) in the dialog and then Esc works again. Guessed? I’m a keyboard fan, not a friend of rodents, so I’d like we get an homogeneous way everywhere with… Esc.

I seems dialogs are created with a default closeOnEsc attribute, but the tabs are not.

Syncthing version

v1.27.5-rc.2

Platform & operating system

Linux

Browser version

Firefox 124

Relevant log output

No response

@bugith bugith added bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated labels Apr 1, 2024
@imsodin imsodin added enhancement New features or improvements of some kind, as opposed to a problem (bug) ui Issues related to the graphical user interface and removed bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) ui Issues related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

2 participants