Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder overlap not detected when using tilde #9400

Open
adiba opened this issue Feb 5, 2024 · 0 comments
Open

Folder overlap not detected when using tilde #9400

adiba opened this issue Feb 5, 2024 · 0 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated

Comments

@adiba
Copy link

adiba commented Feb 5, 2024

Steps to reproduce

  1. After setup, the default folder should be at /home/<username>/Sync. Click 'Add Folder' and enter ~/Sync or ~/Sync/a for the folder path.

Expected behavior

Following text should be shown:

Warning, this path is a subdirectory of an existing folder "Default Folder" (default).

Actual behavior

No warning is shown.

System information

Syncthing v1.27.3-rc.2 on Ubuntu 22

Further comments

I believe it would also be helpful to 1) require checking a box to confirm "I understand the implications" and 2) show the warning in the folder list as well.
Related issue would be detecting overlaps that are caused by symlinks.
As far as I can tell, overlap detection is currently happening on the frontend.

@adiba adiba added bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated labels Feb 5, 2024
@adiba adiba changed the title Tilde not resolved Overlap not detected when using tilde Feb 5, 2024
@adiba adiba changed the title Overlap not detected when using tilde Folder overlap not detected when using tilde Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated
Projects
None yet
Development

No branches or pull requests

1 participant