Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAuthn support in GUI #8409

Open
emlun opened this issue Jul 2, 2022 · 10 comments · May be fixed by #9175
Open

WebAuthn support in GUI #8409

emlun opened this issue Jul 2, 2022 · 10 comments · May be fixed by #9175
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug)

Comments

@emlun
Copy link
Member

emlun commented Jul 2, 2022

I would love to see the GUI support WebAuthn as an alternative to password authentication. Although the Syncthing GUI perhaps doesn't need the strongest security since it's typically not exposed to the whole internet, WebAuthn can still offer a much more pleasant user experience than passwords for those users that prefer it. Personally I use a password manager protected by a YubiKey, and it's rather annoying to have to take the detour through the password manager when I could just tap the YubiKey instead - especially when accessing the Syncthing GUI remotely on my phone, I wouldn't have to switch back and forth between apps to retrieve a password.

I have a working, fairly polished implementation ready, though I expect it'll take a bit more work for it to pass review (most notably, I haven't added any tests yet). Shall I open a pull request, or would you like to discuss it some more first?

@emlun emlun added enhancement New features or improvements of some kind, as opposed to a problem (bug) needs-triage New issues needed to be validated labels Jul 2, 2022
@acolomb
Copy link
Member

acolomb commented Jul 2, 2022

Thank you for offering an actual contribution instead of just asking for a feature, that's great! I personally would welcome the addition, but it is also a bit risky to allow this one technology, as some people may argue that if this is accepted, other solutions should be integrated as well and we don't want feature creep. But OTOH we already have LDAP as a special case and at least WebAuthn is an open, widely available standard.

Please do open a PR where we can discuss the implementation.

@foxxcomm
Copy link

Great work and kudos to emlun! WebAuthn is a fantastic addition to SyncThing as the current basic authentication is EXTREMELY outdated for such a great tool. Will be testing once first beta is available.

@foxxcomm
Copy link

I would like to do some testing on Webauthn support and provide feedback. I downloaded the latest development build (syncthing-windows-amd64-v1.20.4-rc.1.dev.7.g34a5f087.zip) from the build server last night and replaced my syncthing.exe (Windows) but did not see the new options in the GUI. Would you let me know how to enable for testing? Perhaps I downloaded the wrong build? Thanks.

@bt90
Copy link
Contributor

bt90 commented Jul 26, 2022

It's not merged yet. You can follow the development here: #8417

@foxxcomm
Copy link

Thanks. Will monitor and test once it's merged.

Joe

@foxxcomm
Copy link

What is the current status of the development work on Webauthn support? Still don't see this in the development or beta builds. Has development stalled? Would like to help out where we can to move this along. Be happy to test, provide feedback and work on documentation updates if we can get an early build (Windows).

@tomasz1986
Copy link
Contributor

As you can see, the PR is still in a WIP state. If you want to test it now, you'd need to clone the PR author's Syncthing repository, compile Syncthing from the webauthn branch locally, and then run the binary on your system.

@calmh calmh removed the needs-triage New issues needed to be validated label Mar 10, 2023
@foxxcomm
Copy link

foxxcomm commented Jul 6, 2023

Any movement on adding WebAuthn support? Still would love to test and help out!

Thanks

@emlun
Copy link
Member Author

emlun commented Jul 9, 2023

The first step toward it is PR #8757 which will hopefully finish soon. Then we'll see where to go from there, probably resurrect PR #8417 in some way. I have some time to work on this in the next couple of weeks, so hopefully we can get some work done.

@foxxcomm
Copy link

Emlun - Thank You for the update. We stand ready to perform testing and feedback on all the various Windows client and server builds using all the major browsers once a beta build is available. Much appreciate your work as this will add some long overdue polish to the front-end of Syncthing, along with the security benefits which WebAuthn brings.

@emlun emlun linked a pull request Oct 15, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug)
Projects
None yet
6 participants