Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/crashrep: Outdated information about monitor process #687

Closed
acolomb opened this issue Oct 29, 2021 · 2 comments
Closed

dev/crashrep: Outdated information about monitor process #687

acolomb opened this issue Oct 29, 2021 · 2 comments

Comments

@acolomb
Copy link
Member

acolomb commented Oct 29, 2021

The crash reporting section states that no monitor process is used when the --no-restart option or STNORESTART variable is set. That is technically outdated, the monitor process is always used AFAICT.

There is however a method to actually skip the monitor process through the STMONITORED environment variable. Which isn't documented anywhere though, perhaps being considered an internal implementation detail? Anyhow, I spent some time figuring out what the code actually does and the wrong statement here in the docs was actively misleading.

Kindly asking for this to be revised. I would have done it myself if I were confident enough what the code actually evolved into :-/

@tomasz1986
Copy link
Contributor

Related: syncthing/syncthing#7042.

imsodin added a commit to imsodin/docs that referenced this issue Oct 30, 2021
@imsodin
Copy link
Member

imsodin commented Oct 30, 2021

There really isn't much to it: It's running all the time now and STMONITORED is an internal variable/implementation detail only: #688

imsodin added a commit to imsodin/docs that referenced this issue Oct 30, 2021
imsodin added a commit to imsodin/docs that referenced this issue Oct 30, 2021
@calmh calmh closed this as completed in 7a2b637 Oct 30, 2021
@syncthing syncthing locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants