Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unknown_visit to MathDollarReplacer #34

Open
randolf-scholz opened this issue Apr 20, 2023 · 3 comments · May be fixed by #35
Open

Add unknown_visit to MathDollarReplacer #34

randolf-scholz opened this issue Apr 20, 2023 · 3 comments · May be fixed by #35

Comments

@randolf-scholz
Copy link

randolf-scholz commented Apr 20, 2023 •
edited

Currently, sphinx-math-dollar can encounter pending_xref_condition-nodes which will raise an exception. (see sphinx-doc/sphinx#11121).

An example repository that shows the bug is found here: https://github.com/randolf-scholz/sphinx-demo

In short, since sphinx does not officially want to register pending_xref_condition as a node (it is considered an implementation detail), unknwon_visit needs to added to avoid raising the NotImplementedError from the base class.
@asmeurer
Copy link
Member

Sounds reasonable to me.

@hotchilipowder
Copy link

May I ask for a solution? I have the same errors.

@randolf-scholz
Copy link
Author

Pull request #35 is open.

@randolf-scholz randolf-scholz linked a pull request Apr 26, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added unknwon_visit randolf-scholz/sphinx-math-dollar
3 participants
@asmeurer @hotchilipowder @randolf-scholz