-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle creation is broken in 2.7 #2920
Comments
See also #2907 |
@michael-e your PR sadly did not help with my particular problem of untransliterated * in line 347 changing to |
Well, it was not intended to do so. In other words: This is a different issue. |
OK, I see. I was hoping defining a transliterarion for |
Affected Symphony version(s) : 2.7.x
PHP version(s) : all
Handle creation in Symphony 2.7 is broken.
+
characters, for example, will be included in handles, but they should not be. You can even break datasource filtering (by handles) if you include+++
in a string.#2887 escaped literal hyphens in character classes in order to prevent errors in PHP 7.3+. Unfortunatley, one of the fixes (in
General::createHandle
) was erroneous, because the hyphen in question was not meant to be a literal hyphen (but part of a character range instead).I willl send a pull request.
The text was updated successfully, but these errors were encountered: