Making cmake install jx9.h so that the Jx9 API is available to users #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR Matthieu. Jx9 is available as independent implementation and can be downloaded (without the UnQLite core) at https://jx9.symisc.net |
|
Thanks, indeed I could just install the jx9.h file that comes with thee jx9 distribution; it has the proper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it may be needed to call jx9 functions (in my case
jx9_lib_config). These functions are available in the library (the symbols are visible) but are not in the unqlite.h header. This PR makes cmake also install jx9.h. It also slightly modifies jx9.h to (1) define JX9_PRIVATE as empty if it's not defined already (needed for external users to be able to include jx9.h) and (2) add the properextern "C" { }to make the header usable by C++ codes.