Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Real composer scripts #901

Open
shyim opened this issue Apr 26, 2022 · 4 comments 路 May be fixed by #930
Open

Real composer scripts #901

shyim opened this issue Apr 26, 2022 · 4 comments 路 May be fixed by #930

Comments

@shyim
Copy link
Contributor

shyim commented Apr 26, 2022

While using in the manifest composer-scripts I just assumed its the scripts part of the composer.json and thats currently not 馃槄 .

It would be nice to be able to define them like

{
"composer-commands": {
"build-js": "npm run build"
}
}

and then I can run them with composer run build-js. This works already out of the box with Composer when its in the correct key set 馃槄
@JoshuaBehrens
Copy link

Is a makefile an alternative?

@nicolas-grekas
Copy link
Member

Why not. That'd require a new configurator. PR welcome.

morawskim added a commit to morawskim/flex that referenced this issue Jun 8, 2022
@morawskim
feature symfony#901 Real composer scripts
e814e9d
morawskim added a commit to morawskim/flex that referenced this issue Jun 8, 2022
@morawskim
symfony#901 Real composer scripts
15c0815
morawskim added a commit to morawskim/flex that referenced this issue Jun 8, 2022
@morawskim
symfony#901 Real composer scripts
ace28cc
@morawskim morawskim linked a pull request Jun 8, 2022 that will close this issue
Open
@morawskim
Copy link

Hello

I also think that this would be a nice feature.

My user case.
I have created repository with configuration for PHP coding standard.
We have private recipe, which copy file and also modify Makefile - thanks to flex.
I have created PR - which add a new configuration option to recipe composer-commands, so we could migrate to this configurator from Makefile.
Feedback is welcome.

@HeahDude
Copy link
Contributor

Why not. That'd require a new configurator. PR welcome.

@nicolas-grekas You mean like this one? https://github.com/symfony/flex/blob/1.x/src/Configurator/MakefileConfigurator.php#L21
:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Real composer scripts morawskim/flex
5 participants
@nicolas-grekas @morawskim @JoshuaBehrens @shyim @HeahDude