Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Features Request] Subtitles support + Overall MKV support #56

Open
enzomtpYT opened this issue Aug 25, 2023 · 12 comments
Open

[Features Request] Subtitles support + Overall MKV support #56

enzomtpYT opened this issue Aug 25, 2023 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@enzomtpYT
Copy link

Hi ! I've been struggling while downloading some videos and i think some useful features could be added :

  • Downloads of Subtitles
  • Adding MKV support
  • Downloading all audio tracks (from different languages) in one MKV
  • Downloading all Subtitles (from different languages) in one MKV

I am sorry if i am asking too much, ill try to find some way to make what i want to do.

Thanks for make a such great program !

@sylviiu
Copy link
Owner

sylviiu commented Aug 25, 2023

I would absolutely love to look into this! I've never had a use case personally for any of these but I'm willing to put in effort in implementing that :)

Which source are you trying to download from that supports multiple audio streams? I don't know of any personally.

@enzomtpYT
Copy link
Author

Here is an example with multiple Audio Source & Multiple Subtitles : https://www.youtube.com/watch?v=mImFz8mkaHo

@enzomtpYT
Copy link
Author

Also if this can help i found a way to download youtube subtitles by using YT-DL arguements : "--all-subs"

@sylviiu
Copy link
Owner

sylviiu commented Aug 26, 2023

Noted, thank you. I'll look into this!

i actually never knew youtube offered multiple language audio tracks

Downloading with "--all-subs" would only fit with one use case (downloading with FFmpeg disabled, and downloading the original format without conversion -- which might not even embed the subtitles if possible) -- I'd have to find a way to embed it with FFmpeg as well. This can become a "metadata option" here:
image

@sylviiu sylviiu self-assigned this Aug 26, 2023
@sylviiu sylviiu added the enhancement New feature or request label Aug 26, 2023
@sylviiu
Copy link
Owner

sylviiu commented Aug 26, 2023

leaving this as a note for myself

multiple language streams are found in the formats array with the same format ID; e.g. format id 233 has multiple indexes for each languages (233-0, 233-1, etc), where the note specifies the language

image
image
image

i can't tell if this is the same for all services, but crunchyroll languages are through different URLs.

@sylviiu
Copy link
Owner

sylviiu commented Aug 26, 2023

Also, what do you mean by adding MKV support? What's missing from it?

All media encoding & processing is handled by FFmpeg (where applicable); MKV should be supported already?

@enzomtpYT
Copy link
Author

Ok, wait till I get home and I will tell you more
Sorry for making you wait

@enzomtpYT
Copy link
Author

enzomtpYT commented Aug 28, 2023

Also, what do you mean by adding MKV support? What's missing from it?

All media encoding & processing is handled by FFmpeg (where applicable); MKV should be supported already?

Sorry for the late response ! So mkv is already supported by FFmpeg, but after checking mkv support multiple audio streams, i wanted to know if it is possible to make something where you choose what to put (with checkboxes) and then at the end it merge all audio/videos and subtitles in one mkv files with ffmpeg, sorry again if it is too difficult !

@sylviiu
Copy link
Owner

sylviiu commented Sep 2, 2023

Yeah, that would be possible. That's currently my plan for implementing this.

Sorry for being silent past couple days, I've been a little busy outside of software development :( I'll work on this soon!

@enzomtpYT
Copy link
Author

enzomtpYT commented Sep 4, 2023

Sorry for being silent past couple days, I've been a little busy outside of software development :(

It is okay, i don't want to rush you ! Take all the time you need !

@sylviiu
Copy link
Owner

sylviiu commented Jan 14, 2024

finally got around to making some progress :D
image

@Another5405
Copy link

I need the Downloads of Subtitles function too, that will very helpful for my work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants