chore: unify linter configuration with sylabs/sif

[dtrudg]

Type of issue

technical debt

Description of issue

The sylabs/singularity project uses a much less comprehensive set of linters than other projects, such as sylabs/sif

We should aim to unify the set of linters used, by adding, where it is practical, those used by sylabs/sif but not here.

Not all of the linters below will be able to be applied in Singularity. They should be considered individually.

• - asciicheck
• - bidichk
• - bodyclose
• - dogsled
• - dupword
• - errcheck
• - errchkjson
• - errname
• - errorlint
• - exportloopref
• - forcetypeassert
• gochecknoinits not practical at this point
• - gocritic
• godot no practical value
• godox At this point, TODO etc. markers in our code are useful for context, cannot be found as easily with issues.
• - goerr113
• - gomodguard
• - goprintffuncname
• - gosec
• - interfacebloat
• ireturn Not possible without a lot of rewrite for little benefit
• lll Beneficial in some places, but would need lots of nolint for areas where longer lines are clearer
• mirror removed?
• nilnil Not practical given existing widespread coding style
• - nolintlint
• nonamedreturns Aspirational at this time, with some disagreement on universal applicability.
• - prealloc
• - reassign
• - tenv
• thelper Lots of our testing code (esp. in e2e) uses shared functions that aren't "helpers" in this sense
• - typecheck
• unconvert Not at this time. (We have lots of casts that are "superfluous" on one compilation platform but not on another. Plus some casts that are strictly speaking superfluous nevertheless provide crucial information when reading the code.)
• - unparam
• - whitespace