Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:name: + :numref: links do not update properly #812

Open
decimad opened this issue May 7, 2024 · 2 comments
Open

:name: + :numref: links do not update properly #812

decimad opened this issue May 7, 2024 · 2 comments
Labels
bug Something isn't working lsp Issues that relate to the language server
Milestone

Comments

@decimad
Copy link

decimad commented May 7, 2024

Expected behavior

When provided following rst code (numfig = True):

Below are timing diagrams of two constellations with differing producer and consumer periods: :math:`\tau_c = \tau_p` (:numref:`examples.buffer_sharing.figure.timing_double_rate_equal`) and :math:`\tau_c = 2.5\tau_c` (snip).
For both constellations the sensible scenarios **cycle early/cycle late** and **drop early/drop late** are shown. Numbers shown inside the buffer access indicators identify the index of the buffer that is accessed.

.. figure:: images/examples.buffer_sharing.timing_double_rate_equal.svg
    :name:  examples.buffer_sharing.figure.timing_double_rate_equal
    :align: center
    :scale: 180

    Timing diagram for double buffering with :math:`\tau_c = \tau_p`.
    The consumer synchronizes to the producer cycle by issuing wait operations via ``buffer_sink_wait()``.

Should build without error and link the figure properly.

Actual behavior

A fresh esbonio build without pre-existing build directory will link the figure correctly.
However, after changing the :name: property and the :numref: accordingly, the link will fail with warning undefined label: 'examples.buffer_sharing.figure.timing_double_rate_unequal'.
This happens until the build tree was deleted (ie. a restart of the language server does not help).

Log output

No response

(Optional) Settings from conf.py

No response

@decimad decimad added bug Something isn't working triage Issues needing triage labels May 7, 2024
@alcarney alcarney added lsp Issues that relate to the language server and removed triage Issues needing triage labels May 7, 2024
@alcarney
Copy link
Member

alcarney commented May 7, 2024

This sounds like it could be a similar issue to #705, hopefully fixing that will also fix this issue 🤞

@alcarney alcarney added this to the 1.0 milestone May 7, 2024
@decimad
Copy link
Author

decimad commented May 8, 2024

It might actually be the case, that this is a problem within sphinx itself, as I saw similar behavior from the command prompt today. I will investigate this further in the coming days...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lsp Issues that relate to the language server
Projects
Status: Todo
Development

No branches or pull requests

2 participants