Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default keybindings for opening previews in markdown files? #780

Open
alcarney opened this issue Apr 22, 2024 · 1 comment
Open

Default keybindings for opening previews in markdown files? #780

alcarney opened this issue Apr 22, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed ide:vscode Issues that relate to the Esbonio vscode extension
Milestone

Comments

@alcarney
Copy link
Member

Expected behavior

It should be easy to open esbonio's preview from within a markdown file, either through keyboard shortcut or editor menu button

Actual behavior

The when clauses in the extension's package.json need to be updated to consider markdown files.

Log output

No response

(Optional) Settings from conf.py

No response

@alcarney alcarney added bug Something isn't working good first issue Good for newcomers ide:vscode Issues that relate to the Esbonio vscode extension labels Apr 22, 2024
@alcarney alcarney added this to the 1.0 milestone Apr 22, 2024
alcarney added a commit to alcarney/esbonio that referenced this issue Apr 28, 2024
Whereas the reStructuredText part of the extension could copy the
patterns for previews established by VSCode's markdown support, doing
so for markdown files would (surprise, surprise!) create conflicts.

So, the toolbar button and command names have been "re-branded" to
make them distinct from the built-in markdown ones. The
reStructuredText part of the extension keeps its existing
keybindings (for now?) and no keybindings have been set for the
markdown side.

Open for suggestions as to what a good default keybinding could be :)

Ref: swyddfa#780
@alcarney alcarney changed the title It's not easy to open the preview from within a markdown file Default keybindings for opening previews in markdown files? Apr 28, 2024
@alcarney alcarney added help wanted Extra attention is needed and removed good first issue Good for newcomers labels Apr 28, 2024
alcarney added a commit that referenced this issue Apr 28, 2024
Whereas the reStructuredText part of the extension could copy the
patterns for previews established by VSCode's markdown support, doing
so for markdown files would (surprise, surprise!) create conflicts.

So, the toolbar button and command names have been "re-branded" to
make them distinct from the built-in markdown ones. The
reStructuredText part of the extension keeps its existing
keybindings (for now?) and no keybindings have been set for the
markdown side.

Open for suggestions as to what a good default keybinding could be :)

Ref: #780
@alcarney
Copy link
Member Author

Quoting myself from the above commit

Whereas the reStructuredText part of the extension could copy the
patterns for previews established by VSCode's markdown support, doing
so for markdown files would (surprise, surprise!) create conflicts.

So, the toolbar button and command names have been "re-branded" to
make them distinct from the built-in markdown ones. The
reStructuredText part of the extension keeps its existing
keybindings (for now?) and no keybindings have been set for the
markdown side.

Open for suggestions as to what a good default keybinding could be :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed ide:vscode Issues that relate to the Esbonio vscode extension
Projects
Status: Todo
Development

No branches or pull requests

1 participant