Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types missing in latest version #93

Open
BelphegorPrime opened this issue Mar 10, 2023 · 4 comments
Open

types missing in latest version #93

BelphegorPrime opened this issue Mar 10, 2023 · 4 comments

Comments

@BelphegorPrime
Copy link
Contributor

BelphegorPrime commented Mar 10, 2023

Hi, there are some type definitions, in the currenty released version, mssing.

I tried to upgrade from 3.18.2 to 3.20.1

the type definition for InputPayment here

interface InputPaymentElement extends InputPayment {
is undefined.

also InputPaymentElementApple and InputPaymentRedirect are not exported here

InputPaymentElementApple,
from the payments definition, because they aren't defined.

Without that the library is not useable.

@BelphegorPrime
Copy link
Contributor Author

looks like there are some problems with the type definition in payment/index.d.ts

For example the interface InputPaymentElementCard is defined twice
it was written by @vstudenichnik-insoft and @mustafaswell

@mustafaswell
Copy link
Contributor

Thanks for the ping @BelphegorPrime. I'll take a look!

@gusfune
Copy link

gusfune commented Mar 22, 2023

This was also reported on #81 which still have a bunch of open issues on types.

@mustafaswell
Copy link
Contributor

Thank you @BelphegorPrime and @gusfune for reporting. The latest release of Swell-JS contains the patches you had mentioned. Please continue to let us know should you find any gaps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants