Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify statement "the total count of each type of animal" in "Pipes and filters" challenge #1453

Open
DaniMori opened this issue Mar 5, 2024 · 1 comment

Comments

@DaniMori
Copy link

DaniMori commented Mar 5, 2024

How could the content be improved?

Very minor improvement, but I'd like to suggest to correct this exercise statement (which led me to confusion while reading it for the first time):

the total count of each type of animal in the file?

My first impression was that what was being asked was, e.g. "the total number of deers, rabbits, etc." which, as understood from the naming of files and folders, could be "the sum of the last column, for each type of animal" (i.e. aggregating all the counts in all the dates).

Only after seeing the solution I noticed that it is "the total number of times each animal appears in the file" (that is, how many lines contain each animal type).

I'd suggest to change it to

-the total count of each type of animal in the file?
+how many times each type of animal appear in the file?

Which part of the content does your suggestion apply to?

https://github.com/swcarpentry/shell-novice/blob/main/episodes/04-pipefilter.md

@bkmgit
Copy link
Contributor

bkmgit commented Mar 25, 2024

@DaniMori Thanks for this. Will make the change, but you are also welcome to make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants