Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open graph meta tags #871

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

pulbee
Copy link

@pulbee pulbee commented Sep 28, 2021

  • I've checked that this isn't a new swag opportunity proposal.
  • I've checked that this isn't a duplicate pull request.

Added open graph meta tags to enhance share preview on social media.

Fixes #333

@pulbee pulbee mentioned this pull request Sep 29, 2021
@aslafy-z aslafy-z changed the title Added open graph meta tags ( Facebook ) feat: open graph meta tags Sep 29, 2021
src/pug/includes/head.pug Outdated Show resolved Hide resolved
src/pug/includes/head.pug Outdated Show resolved Hide resolved
@aslafy-z aslafy-z mentioned this pull request Sep 29, 2021
1 task
@aslafy-z
Copy link
Collaborator

Thank you @pulbee for this PR. I added few suggestions. Could you please review them?

The image would act as a site preview across social networks.
Replaced "name" field in meta tags with "property", And replaced the og:image field value to a relative image path.
@pulbee pulbee requested a review from aslafy-z October 2, 2021 06:22
Copy link
Collaborator

@aslafy-z aslafy-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup metadata tags (OpenGraph)
2 participants