WIP: Allow all extensions in links #619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tshort, currently all extensions are not allowed for performance reasons (workspace cache is rebuilt on restart), for example, there could be users where knowledge base is located next to deeply nested folders like |
|
I'll play around with configurable options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's nice to be able to link to more types of files than the default. That could be code (
py,js,sh), data (csv), configuration files (yaml), or anything else.This fixes #592 and #593.
I've tried this out, and it works well. It's WIP because:
If this approach is desired, the extension code probably needs some work. There's no need for
otherExts. The code could treat extensions as one of: markdown, images, and everything else.I assume tests need to be update.