Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making atom-svelte package official? #70

Closed
duruer opened this issue May 8, 2020 · 10 comments
Closed

Making atom-svelte package official? #70

duruer opened this issue May 8, 2020 · 10 comments

Comments

@duruer
Copy link

duruer commented May 8, 2020

I love to use Atom but svelte package for it, so old, so like is there anyway to talk with the author and make it official package?
It would be better language supporting I guess..

@dummdidumm
Copy link
Member

I guess you mean the plugin from this repo? @orta for me it seems pretty straight forward to add this, not much code. On the other hand, if we add official plugins for all IDEs this might get cumbersome at some point. Then again, Atom is a popular IDE. What do you think?

@duruer
Copy link
Author

duruer commented May 8, 2020

I guess you mean the plugin from this repo?

Yeah this is what I meant.

@robinloeffel
Copy link

I strongly second @kahverengi001. The only thing holding me back from really utilizing Svelte in private projects and maybe even pushing it at work is having no support at all for it in Atom—see sveltejs/svelte-atom#3 and sveltejs/svelte-atom#8.

@orta
Copy link
Contributor

orta commented May 8, 2020

I'm not against it. I am hesitant though.

I'm happy to set up the deploy infra etc but it'll need its own contributors. Considering that the atom-svelte repo has been around for 2 years and has only received one PR. It doesn't look like something people are actively working to improve and own it. That is the real sign of whether we'd be able to handle it here.

Moving the extension into this repo could also just leave it unused but now with the expectation is that people who are working on the vscode infra will also need to support atom too, which isn't going to be the case.

@robinloeffel / @kahverengi001 are you interested in actively working and maintaining it?

@dummdidumm
Copy link
Member

As an alternative, we could make a PR in the current repo to simply update the dependency. This should be enough (I hope).

@duruer
Copy link
Author

duruer commented May 8, 2020

@kahverengi001 are you interested in actively working and maintaining it?

Well, I want to help development for Atom extension but I just don't even know where to start honestly. I need to check what has done and what can I do and how can I do about it. I can just simply open pull requests for whatever I have done.

This means yes, I'm interested.

@RedHatter
Copy link

I'm happy to set up the deploy infra etc but it'll need its own contributors. Considering that the atom-svelte repo has been around for 2 years and has only received one PR. It doesn't look like something people are actively working to improve and own it.

I use atom as my daily editor as do some of my co-workers. Svelte is a large part of our code base and bad plugin support has been a thorn in our foot for a while. I had considered contributing in the past but was hesitant based my previous experience with the author. I didn't was to spend time working on it then have my PR sit there.

If the plugin was given I new home here and not ignored I would be happy to help.

@orta
Copy link
Contributor

orta commented Jun 4, 2020

#160 starts to move it into this repo

@rixo
Copy link
Contributor

rixo commented Feb 15, 2022

The Atom plugin repository is now owned by the Svelte org, and I have just published a new updated version of the plugin, so the Svelte org now appears as the maintainer of the plugin in the Atom registry. I believe this means that the Atom plugin is de facto officially supported by Svelte now.

I'm not sure it would be possible to move the Atom plugin repo into the language tools monorepo, though, and still be able to publish to the Atom registry. I strongly doubt it actually, even if I might be mistaken.

I think this issue can be closed, and work/feedback on the Atom plugin can carry on in the (official!) svelte-atom repo.

@dummdidumm
Copy link
Member

Great work @rixo 🎉
Moving it into this monorepo doesn't work, it was tried before and apparently Atom can't deal with this type of repository (#160 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants