Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Signed Integers in Native Pixel Data #294

Open
suyashkumar opened this issue Nov 6, 2023 · 2 comments
Open

Check for Signed Integers in Native Pixel Data #294

suyashkumar opened this issue Nov 6, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@suyashkumar
Copy link
Owner

The Pixel Representation Attribute can and should be inspected to determine if the pixel data values are signed integers or not. At the moment unsigned is assumed, and we should return an error if the data is signed. We should also support pulling in signed integers as well.

@suyashkumar
Copy link
Owner Author

Put up a quick draft in #296 to return an error, but need to check a couple more things. It might not be too hard to just go ahead and parse the signed and unsigned ints outright.

@suyashkumar suyashkumar changed the title Check for and support Signed Integers in Native Pixel Data Check for Signed Integers in Native Pixel Data Nov 6, 2023
@suyashkumar
Copy link
Owner Author

Probably the right way to handle this is to support multiple data types for PixelData, including floats. This would also help with #291 and #161 as well if we allowed the parsed values to be differently sized ints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant