New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

None should not be observed before data #70

Open

Joearrowsmith opened this issue Apr 18, 2023 · 3 comments

Assignees

Labels

bug

Collaborator

Joearrowsmith commented Apr 18, 2023

Joearrowsmith added the bug label

Joearrowsmith assigned dswigh

Collaborator Author

Joearrowsmith commented Apr 18, 2023

except for yields?

Collaborator Author

Joearrowsmith commented Apr 18, 2023

I added a test that catches this behaviour. @dswigh please fix

Collaborator Author

Joearrowsmith commented Apr 18, 2023

We should be careful to note the cause of this, I believe it is because reactions that have invalid SMILES are not being removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment