Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only test remove_inconsistent_yields once #136

Open
dswigh opened this issue Jun 6, 2023 · 0 comments
Open

Only test remove_inconsistent_yields once #136

dswigh opened this issue Jun 6, 2023 · 0 comments

Comments

@dswigh
Copy link
Collaborator

dswigh commented Jun 6, 2023

Tests take a long time, and one reason is that we've got remove_inconsistent_yields as a bool that we vary with two other bools a lot of times. This means we have (3x3=9) test cases in the cleaner instead of (2x2=4), and in the extractor we are also extracting all data multiple times with remove_inconsistent_yields=T/F. It's a relatively simple function, so we should just have a separate test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant