New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: DevMode draggable #522
Comments
@minsoo-web @okinawaa I think it's last feature to make I guess this have two requirement.
|
I'm wondering what value there might be in making it draggable. |
I thought devMode's position need to be like iPhone's AssistiveTouch We have position already. but we need to code other postion to avoid blocking uis if there is blocked uis by DevMode. I thought it' not good for DX. so I just want to make DevMode's position should be changeable and draggable and It will make library users won't feel annoying DevMode's position problem. I'm curious about your opinion for this feature. @minsoo-web |
I added this as v2 minor feature |
Oh, I think I've been in the situation you're talking about. I agree that it's not a good DX when the dev tool covers the ui. I think it's a good idea to make it draggable! |
@minsoo-web, you are right. I thought it like you too. (naming like @suspensive/react-devtools also good for me) To do this, I thought "overriding type interface" with d.ts file to support devMode prop externally like typing extends theme of emotion ThemeProvider like below // Suspense.tsx
interface SuspenseProps extends ReactSuspenseProps, DevModePropOverride["Suspense"] {
...
} // suspensive.d.ts on library user's code
import { SuspensiveDevModeProp } from '@suspensive/react-dev-mode'
declare module '@suspensive/react' {
export interface DevModePropOverride extends SuspensiveDevModeProp {}
} |
Package Scope
@suspensive/react
Description
Draggable DevMode
Possible Solution
No response
etc.
No response
The text was updated successfully, but these errors were encountered: