Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.on functions don't work with d3 v6 #98

Open
martingraham opened this issue Nov 12, 2020 · 2 comments
Open

.on functions don't work with d3 v6 #98

martingraham opened this issue Nov 12, 2020 · 2 comments

Comments

@martingraham
Copy link

The .on functions need updating to accommodate d3 v6 - now for .on events, the event is the first argument and the datum (d) the second. https://github.com/d3/d3/blob/master/CHANGES.md

It means for v6 we now get the mouseevent returned as 'd' in d3-legend functions like .on("cellclick", function(d){alert("clicked " + d);});

Checking the code there is no second argument returned so .on("cellclick", function(ev, d){alert("clicked " + d);}); doesn't work

@WuglyakBolgoink
Copy link

WuglyakBolgoink commented Jul 13, 2021

have the same issue...

@susielu any progress?

@gdelpuente
Copy link

look at this fork
d3-v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants