Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"wrap" is performance heavy #43

Open
pbadenski opened this issue Nov 29, 2017 · 3 comments
Open

"wrap" is performance heavy #43

pbadenski opened this issue Nov 29, 2017 · 3 comments

Comments

@pbadenski
Copy link
Contributor

I have a dynamically updating graph on a page with annotations. It updates around 2-3 times per second. It's working rather well with the only exception of "wrap" calls which incur a big performance penalty (probably 60% - 80% of the total cost of rendering the annotation).

One way to address that would be to allow the user to disable wrapping. Not ideal - but does the trick when performance is the priority.

@susielu
Copy link
Owner

susielu commented Nov 29, 2017

What is the code you're using on update? Are you re-calling the function or using the .update() function? the .update() shouldn't re-wrap it should only handle position changes. I'm curious if you're seeing otherwise though.

@pbadenski
Copy link
Contributor Author

Recalling the function. I think this is only option for me - labels are dynamic and I'm using dynamic force-directed positioning for notes.

@susielu
Copy link
Owner

susielu commented Nov 29, 2017

Ahh okay so your text is changing while it animates? (just curious) regardless I think it makes sense to add a 'don't wrap' option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants