Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haptics example not working #313

Open
klyap opened this issue Feb 10, 2023 · 2 comments
Open

Haptics example not working #313

klyap opened this issue Feb 10, 2023 · 2 comments

Comments

@klyap
Copy link
Contributor

klyap commented Feb 10, 2023

  1. The sample page gives me this error "Connection timed out Error code 522": https://supermedium.com/superframe/components/haptics/
  2. The code sample also doesn't work for me, even after I updated AFrame version to 1.4.1
    running the code in Glitch gives me console errors:
hand-controls.js:198 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'charAt')
    at n.update (hand-controls.js:198:59)
    at n.initComponent (component.js:333:10)
    at n.updateProperties (component.js:305:12)
    at e.exports.Component (component.js:81:8)
    at new n (component.js:665:15)
    at d.initComponent (a-entity.js:319:17)
    at d.updateComponent (a-entity.js:471:10)
    at d.updateComponents (a-entity.js:442:12)
    at a-entity.js:243:12
    at a-node.js:143:17
    ```

@diarmidmackenzie
Copy link
Contributor

Not sure what's going on with the hosted examples at supermedium.com.

In terms of your glitch, the code for this example is out of date (not updated since A-Frame 0.7.0 !)

The schema for hand-controls has changed, so instead of
hand-controls="left"

you need:
hand-controls="hand:left"

That's the cause of the error.
Remixed clitch with this fixed is here:
https://obvious-scratched-harmonica.glitch.me/haptics.html

I don't have time just now to test in VR, so not sure if that's the only problem, but hopefully you can test with this glitch & update this issue with your findings.

@klyap
Copy link
Contributor Author

klyap commented Feb 10, 2023

Just tested the Glitch on a headset and verified that it works! Here's a PR to fix the haptics example: #314

Also heads up I'm seeing hand-controls="left" in a couple other older examples/scenes in this repo, but they also seem like they may have other issues besides just this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants