Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening keyboard freezes page. It doesn't work #186

Open
dmarcos opened this issue Feb 16, 2024 · 8 comments
Open

Opening keyboard freezes page. It doesn't work #186

dmarcos opened this issue Feb 16, 2024 · 8 comments

Comments

@dmarcos
Copy link
Member

dmarcos commented Feb 16, 2024

I merged this #175 to bump to A-Frame 1.3.0 and I've got reports that keyboard no longer works (Quest 2 and 3). @redsolver anything quick comes to mind? Thanks so much

@dmarcos
Copy link
Member Author

dmarcos commented Feb 16, 2024

More info from users:

-The crash occurs when you simply hover over the keyboard, most times you do not need to interact with the actual keys, it is the keyboard field.
-Menu Resolution appears to be lower, within maps might be similar as well
-The end of the first map you play after loading/reloading the website loops the intro for about 1.5-2 seconds, then goes to stats screen
-Stats screen does not show "Rank" you receive on stats screen (S, A, B, C)

@unsupervisednn
Copy link

Yea I had based my PR on that one and found out the super-keyboard expects different UV mapping API in Three.js

@dmarcos
Copy link
Member Author

dmarcos commented Feb 17, 2024

@unsupervisednn thanks .if you have some code to quickly fix the keyboard I'll deploy it. Otherwise will have to revert the A-Frame 1.3.0

@unsupervisednn
Copy link

It was crashing a bit more while playing on a-frame 1.3.0. I dont personally use this with Windows Chrome so didn't feel it was worth lots of QA and debugging to update a-frame when the older version worked fine on quest browser, sorry

@frabul
Copy link
Contributor

frabul commented Feb 22, 2024

I tried it a few hours ago and the bug was gone....

@digama0
Copy link
Contributor

digama0 commented Feb 28, 2024

The issue with the rank ('S', 'A', 'B', ...) text not showing up still exists, and the console shows issues with FontLoader and TextGeometry having moved out of three.js (they are only stubs now, so naturally it would not render). I tried fixing it by using

import { FontLoader } from "super-three/examples/jsm/loaders/FontLoader";
import { TextGeometry } from "super-three/examples/jsm/geometries/TextGeometry";

and adding "super-three": "^0.137.0" to the packages.json, but this seems to yeet the camera to NaN on first render, so I'll see if someone who knows the system better can propose a better fix.

@frabul
Copy link
Contributor

frabul commented Feb 28, 2024

Why the three version that is included in AFRAME does not include FontLoader and TextGeometry examples?

@frabul
Copy link
Contributor

frabul commented Feb 29, 2024

The way i did is

  • Take TextGeometry.js and FontLoader.js from the super-three v0.137 and copy to src/lib
  • Modify TextGeometry.js by replacing
import {
	THREE.ExtrudeGeometry
} from 'three';

with
var ExtrudeGeometry = THREE.ExtrudeGeometry;

  • Modify text-geometry.js by adding
import { TextGeometry } from '../lib/TextGeometry.js';
THREE.TextGeometry = TextGeometry;
import { FontLoader } from '../lib/FontLoader.js';
THREE.FontLoader = FontLoader;

It seems to work without any side effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants