Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrElse callback should be able to change Ok type #484

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

OrElse callback should be able to change Ok type #484

wants to merge 3 commits into from

Conversation

braxtonhall
Copy link

@braxtonhall braxtonhall commented Jun 29, 2023 •
edited

Unfortunately this would be a breaking change, as anyone who explicitly annotated the types like orElse<A>(foo) will need to update their code to orElse<U, A>(foo)

@braxtonhall braxtonhall marked this pull request as ready for review June 29, 2023 13:28
@supermacro
Copy link
Owner

#496

@myftija
Copy link

myftija commented Nov 4, 2023

@supermacro Any updates on this? Would be really great to have this behavior for orElse :)

@jdisho
Copy link

jdisho commented Dec 24, 2023 •
edited

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

orElse returns the wrong type when the callback changes the ok type orElse should accept new Ok types
4 participants
@braxtonhall @supermacro @myftija @jdisho