Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Super Editor] [Android] Unable to open the keyboard once I hide it with the system button. #1816

Closed
IResetic opened this issue Jan 22, 2024 · 3 comments · Fixed by #1978
Closed

[Super Editor] [Android] Unable to open the keyboard once I hide it with the system button. #1816

IResetic opened this issue Jan 22, 2024 · 3 comments · Fixed by #1978
Assignees
@angelosilvestre
Labels
area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 1 1hr or less type_bug Something isn't working

Comments

@IResetic
Copy link

Package Version
Github stable version.

To Reproduce
Steps to reproduce the behavior:

  1. Open the example app on Android device with option to hide the keybaord.
  2. From the drawer menu select "Text with hint".
  3. Click on the first "header goes here...".
  4. After the keyboard is open press the system button to hide/close the keybaord.
  5. After the keybaord is hidden, click again on the same (first one) "header goes here...".

Actual behavior
The keyboard stays hidden and I'm not able to enter the text.

Expected behavior
I expect the keybaord to re-appear so I can add text.

Platform
Samsung A50 with Android 11

Flutter version
Flutter 3.16.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 2e9cb0aa71 (6 weeks ago) • 2023-12-11 14:35:13 -0700
Engine • revision 54a7145303
Tools • Dart 3.2.3 • DevTools 2.28.4
@IResetic IResetic added the type_bug Something isn't working label Jan 22, 2024
@IResetic IResetic changed the title [Super Editor] Unable to open the keyboard once I hide it with the system button. [Super Editor] [Android] Unable to open the keyboard once I hide it with the system button. Jan 22, 2024
@matthew-carroll matthew-carroll added area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 1 1hr or less labels Feb 7, 2024
@angelosilvestre
Copy link
Collaborator

@matthew-carroll The issue is that we only show the software keyboard when the selection changes. Tapping at an empty node doesn't change the selection, so the keyboard isn't shown. We had a large refactor on the IME on #876, but looking at the previous code it seems this bug was present even before the PR.

We can pass the SoftwareKeyboardController to the mobile touch interactors. Although a user might use a physical keyboard on a mobile device, I think it's safe to assume that most of the times a mobile user will be using a software keyboard, so I think it should be ok to add a reference to SoftwareKeyboardController in the mobile interactors.

Any other ideas?

@hawkkiller
Copy link

@matthew-carroll @angelosilvestre we hit this bug as well.

What's the reasoning behind "showing keyboard only when selection changes"?

@angelosilvestre
Copy link
Collaborator

What's the reasoning behind "showing keyboard only when selection changes"?

@hawkkiller It's just an implementation detail. We should change that to fix this issue.

angelosilvestre added a commit that referenced this issue Apr 30, 2024
@angelosilvestre
[SuperEditor] Show software keyboard upon tap (Resolves #1816)
da1210d
@angelosilvestre angelosilvestre mentioned this issue Apr 30, 2024
Merged
matthew-carroll pushed a commit that referenced this issue May 20, 2024
@angelosilvestre
[SuperEditor] Show software keyboard upon tap (Resolves #1816) (#1978)
2597d97
github-actions bot pushed a commit that referenced this issue May 20, 2024
@angelosilvestre @web-flow
[SuperEditor] Show software keyboard upon tap (Resolves #1816) (#1978)
d7057d1
matthew-carroll pushed a commit that referenced this issue May 20, 2024
@angelosilvestre @matthew-carroll
[SuperEditor] Show software keyboard upon tap (Resolves #1816) (#1978)
8a8b2ba
quaaantumdev pushed a commit to quaaantumdev/super_editor that referenced this issue May 23, 2024
@angelosilvestre @quaaantumdev
[SuperEditor] Show software keyboard upon tap (Resolves superlistapp#…
2eefa51 
…1816) (superlistapp#1978)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelosilvestre angelosilvestre

Labels
area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 1 1hr or less type_bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SuperEditor] Show software keyboard upon tap (Resolves #1816) superlistapp/super_editor
4 participants
@matthew-carroll @angelosilvestre @hawkkiller @IResetic