Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: magnifier entrance and exit animation, and shape #1958

Closed
BazinC opened this issue Apr 22, 2024 · 0 comments · Fixed by #1973
Closed

iOS: magnifier entrance and exit animation, and shape #1958

BazinC opened this issue Apr 22, 2024 · 0 comments · Fixed by #1973
Assignees
@angelosilvestre
Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor area_supertextfield Pertains to SuperTextField bounty_junior f:clickup time: 5 type_enhancement New feature or request

Comments

@BazinC
Copy link

BazinC commented Apr 22, 2024

User Behavior
Match the iOS 17 native "Loupe" (magnifying glass). For now the magnifier entrance and exit animation, and shape doesn't match native component.

See below: iOS native behavior. Message app

native.ios.magnifier.webm
  • Bigger loupe
  • Border to better sepateration between overlay and content behind
  • Border color matches the cursor color
  • Entrance/Exit animation

See below: iOS SuperEditor behavior. Example app. Use IOSFollowingMagnifier.roundedRectangle

supereditor.ios.magnifier.webm

See below: Flutter Textfield on iOS. Even flutter doesn't match native.

flutter.textfield.magnifier.webm

Feature Value
iOS users love to have the same "native" UI/UX feel. They can complain when the experience is different and tell you're app doesn't feel polish.

Additional context
https://www.macobserver.com/tips/how-to/text-magnification-ios-17/
https://developer.apple.com/videos/play/wwdc2023/10058/
@BazinC BazinC added the type_enhancement New feature or request label Apr 22, 2024
@matthew-carroll matthew-carroll added area_supereditor Pertains to SuperEditor area_supertextfield Pertains to SuperTextField bounty_junior area_super_reader Related to SuperReader time: 5 f:clickup labels Apr 23, 2024
angelosilvestre added a commit that referenced this issue Apr 28, 2024
@angelosilvestre
[SuperEditor][SuperReader][SuperTextField] Update iOS magnifier (Reso…
8abf4f9 
…lves #1958)
@angelosilvestre angelosilvestre mentioned this issue Apr 28, 2024
Merged
matthew-carroll pushed a commit that referenced this issue May 18, 2024
@angelosilvestre
[SuperEditor][SuperReader][SuperTextField] Update iOS magnifier (Reso…
d2aeb94 
…lves #1958) (#1973)
github-actions bot pushed a commit that referenced this issue May 18, 2024
@angelosilvestre @web-flow
[SuperEditor][SuperReader][SuperTextField] Update iOS magnifier (Reso…
f777654 
…lves #1958) (#1973)
matthew-carroll pushed a commit that referenced this issue May 20, 2024
@angelosilvestre @matthew-carroll
[SuperEditor][SuperReader][SuperTextField] Update iOS magnifier (Reso…
c21e04f 
…lves #1958) (#1973)
quaaantumdev pushed a commit to quaaantumdev/super_editor that referenced this issue May 23, 2024
@angelosilvestre @quaaantumdev
[SuperEditor][SuperReader][SuperTextField] Update iOS magnifier (Reso…
4a6aa31 
…lves superlistapp#1958) (superlistapp#1973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelosilvestre angelosilvestre

Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor area_supertextfield Pertains to SuperTextField bounty_junior f:clickup time: 5 type_enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@BazinC @matthew-carroll @angelosilvestre