Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Caret position is wrong when dealing with ImageNode #1959

Closed
BazinC opened this issue Apr 22, 2024 · 0 comments · Fixed by #1967
Closed

Mobile: Caret position is wrong when dealing with ImageNode #1959

BazinC opened this issue Apr 22, 2024 · 0 comments · Fixed by #1967
Assignees
@angelosilvestre
Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:clickup time: 1 1hr or less type_bug Something isn't working

Comments

@BazinC
Copy link

BazinC commented Apr 22, 2024

Package Version
Stable or main branch

To Reproduce
On SuperEditor Editor Demo:

  • Tap on the left side of an image.
  • The cursor is placed on the left side of the image.
  • Tap backspace ➝ nothing happens, as expected, since you are at the beginning of the document.
  • Tap on the right side of the image.
  • The cursor remains on the left side.
  • Tap backspace ➝ the image block is deleted, indicating that the selection was actually on the right.
cursor_does_not_represent_real_selection.webm

Actual behavior
The caret position on screen does not represent the real selection position.

Expected behavior
When taping on the right side of the image, the caret should be visible along the right side of the image

Platform
iOS and Android

Flutter version
[✓] Flutter (Channel stable, 3.19.6, on macOS 14.3 23D56 darwin-arm64, locale en-FR)

Screenshots

Additional context
Add any other context about the problem here.
@BazinC BazinC added the type_bug Something isn't working label Apr 22, 2024
@matthew-carroll matthew-carroll added area_supereditor Pertains to SuperEditor bounty_junior time: 1 1hr or less area_super_reader Related to SuperReader f:clickup labels Apr 23, 2024
angelosilvestre added a commit that referenced this issue Apr 24, 2024
@angelosilvestre
[SuperEditor][Mobile] Fix downstream image caret position (Resolves #…
2dc379c 
…1959)
@angelosilvestre angelosilvestre mentioned this issue Apr 24, 2024
Merged
angelosilvestre added a commit that referenced this issue May 8, 2024
@angelosilvestre
[SuperEditor][Mobile] Fix downstream image caret position (Resolves #…
2d3612d 
…1959)
matthew-carroll pushed a commit that referenced this issue May 13, 2024
@angelosilvestre
[SuperEditor][Mobile] Fix downstream image caret position (Resolves #…
5481c4e 
…1959) (#1967)
github-actions bot pushed a commit that referenced this issue May 13, 2024
@angelosilvestre @web-flow
[SuperEditor][Mobile] Fix downstream image caret position (Resolves #…
45f54df 
…1959) (#1967)
angelosilvestre added a commit that referenced this issue May 14, 2024
@angelosilvestre
[SuperEditor][Mobile] Fix downstream image caret position (Resolves #…
94f1352 
…1959) (#1967)
matthew-carroll pushed a commit that referenced this issue May 15, 2024
@github-actions @angelosilvestre
Cherry Pick: [SuperEditor][Mobile] Fix downstream image caret position (
d957a48 
Resolves #1959) (#1995)

[SuperEditor][Mobile] Fix downstream image caret position (Resolves #1959) (#1967)

Co-authored-by: Angelo Silvestre <angelosilvestre.ccp@gmail.com>
quaaantumdev pushed a commit to quaaantumdev/super_editor that referenced this issue May 16, 2024
@github-actions @angelosilvestre @quaaantumdev
Cherry Pick: [SuperEditor][Mobile] Fix downstream image caret position (
ccfb382 
Resolves superlistapp#1959) (superlistapp#1995)

[SuperEditor][Mobile] Fix downstream image caret position (Resolves superlistapp#1959) (superlistapp#1967)

Co-authored-by: Angelo Silvestre <angelosilvestre.ccp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelosilvestre angelosilvestre

Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:clickup time: 1 1hr or less type_bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SuperEditor][Mobile] Fix downstream image caret position (Resolves #1959) superlistapp/super_editor
3 participants
@BazinC @matthew-carroll @angelosilvestre