Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception thrown when dragging Android handles after cut or regular delete #1936

Closed
jellynoone opened this issue Apr 12, 2024 · 0 comments · Fixed by #1951
Closed

Exception thrown when dragging Android handles after cut or regular delete #1936

jellynoone opened this issue Apr 12, 2024 · 0 comments · Fixed by #1951
Assignees
Labels
area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 5 type_bug Something isn't working

Comments

@jellynoone
Copy link

jellynoone commented Apr 12, 2024

Package Version
main

To Reproduce
The behavior can be reproduced in the example application.

Steps to reproduce the behavior:

  1. Run example application on an Android device
  2. Select text
  3. Select cut from editing toobar
  4. See non-collapsed text selection handles
  5. Attempt to drag one
  6. Observe Exception: Tried to drag an expanded Android handle but the selection is collapsed. followed by Exception: Tried to pan an Android drag handle but the focal point is null. The focal point is set when the drag begins. This shouldn't be possible.

The same behavior can be observed if the selected text is removed via backspace not just cut.

Additionally, when text is cut or deleted and you type something, the text selection handlers continue to indicate an uncollapsed selection even though it is actually collapsed.

Actual behavior
The selection handlers indicate a non-collapsed document selection and it seems other parts of super_editor don't expect this.

Expected behavior
After cut or deletion, the selection handlers should probably be removed or collapsed.

Platform
Android

Flutter version

Flutter 3.19.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 300451adae (3 weeks ago) • 2024-03-27 21:54:07 -0500
Engine • revision e76c956498
Tools • Dart 3.3.3 • DevTools 2.31.1
@jellynoone jellynoone added the type_bug Something isn't working label Apr 12, 2024
@matthew-carroll matthew-carroll added area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 5 labels Apr 14, 2024
angelosilvestre added a commit that referenced this issue Apr 20, 2024
matthew-carroll pushed a commit that referenced this issue May 20, 2024
github-actions bot pushed a commit that referenced this issue May 20, 2024
matthew-carroll pushed a commit that referenced this issue May 20, 2024
quaaantumdev pushed a commit to quaaantumdev/super_editor that referenced this issue May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 5 type_bug Something isn't working
Projects
None yet
3 participants