Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperIOSTextField] Update text selection handles sizing and layout to match native iOS design spec #1924

Open
rutvik110 opened this issue Apr 8, 2024 · 0 comments
Assignees
Labels
area_supertextfield Pertains to SuperTextField bounty_junior f:superlist Funded by Superlist platform_ios Applies to use on iOS time:2

Comments

@rutvik110
Copy link
Collaborator

SuperIOSTextField text selection handles doesn't follow the native iOS design specs as documented here. This includes the text selection handle bar and the circle that is shown above/below the handle.

Need to update following things to match the native behaviour:

  • iOS uses handle circle radius of 6px under all circumstances. SuperIOSTextField currently uses 4px. Update that. read
  • On iOS, the drag handle rectangles are exactly as tall as the selection highlight rectangle for a given line, and the top and bottom of those handle rectangles match the selection rectangle. Update the handle bar layout to match the native behaviour. read
  • On iOS, the drag handle circle sits completely above/below the very top/bottom edge of the handle. SuperIOSTextField circle overlaps with the selection area. Update it. read
@rutvik110 rutvik110 added the area_supertextfield Pertains to SuperTextField label Apr 8, 2024
@rutvik110 rutvik110 self-assigned this Apr 8, 2024
@matthew-carroll matthew-carroll added platform_ios Applies to use on iOS bounty_junior f:superlist Funded by Superlist time:2 labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area_supertextfield Pertains to SuperTextField bounty_junior f:superlist Funded by Superlist platform_ios Applies to use on iOS time:2
Projects
None yet
Development

No branches or pull requests

3 participants