Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating a SQL RLS query with IA has UI with low contrast (improve accessibility) #23245

Open
2 tasks done
Huilensolis opened this issue Apr 24, 2024 · 9 comments
Open
2 tasks done
Labels
a11y Issues related to improving accessibility bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@Huilensolis
Copy link

Huilensolis commented Apr 24, 2024

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

When creating a SQL RLS query with IA, the UI has low contrast. this is difficult to read for people with vision problems and those without.

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Go to a table in your table editor (supabase.com)
  2. Click on "add RLS policy"
  3. click on "Create policy"
  4. on the top of the SQL edit box, click on the "open SQL editor" button
  5. ask the IA to write some query
  6. see the UI

Expected behavior

image
the text inside the input box has low contrast, it should be more bright.

image
the keymap "CTRL" has low contrast, it's hard to see it

image
the keymap "ESC" in the button "discard" is almost invisible. increase contrast.

image
some of the "git difference" indicators in each line difficult to read the text.
the top text on the right query editor has low contrast, it should be incremented.

System information

  • OS: [e.g. macOS, Windows]
  • Browser (if applies) [e.g. chrome, safari]
  • Version of supabase-js: [e.g. 6.0.2]
  • Version of Node.js: [e.g. 10.10.0]

some of the issues are easy to fix with CSS, but the SQL text editor is more difficult since I guess supabase is using an integration of vs code in some way (I don't know), but I guess it could be fixed by editing the theme.

hope it helps!

@Huilensolis Huilensolis added the bug Something isn't working label Apr 24, 2024
@Huilensolis
Copy link
Author

I'm sorry for using the label "bug" for this issue, but I could not find any other issue template that was under the category of "this could improve, but its not a bug" : (

@encima encima added enhancement New feature or request a11y Issues related to improving accessibility labels Apr 25, 2024
@bl-aire
Copy link

bl-aire commented Apr 27, 2024

Hi @Huilensolis @encima,

Can I work on this?

@encima
Copy link
Contributor

encima commented Apr 27, 2024

Hi @Huilensolis @encima,

Can I work on this?

sure. you don't need permissions from anyone! go ahead and open a PR. thanks!

@Huilensolis
Copy link
Author

How can I know if an issue is planned or not? If fhe issue has a tag assigned by te repo members, does that mean that it is planned to be implemented and I can open a pr? How does it work?

@bl-aire
Copy link

bl-aire commented Apr 28, 2024

Hi @Huilensolis @encima,

Can I work on this?

sure. you don't need permissions from anyone! go ahead and open a PR. thanks!

Okay. Thank you

@encima
Copy link
Contributor

encima commented Apr 28, 2024

How can I know if an issue is planned or not? If fhe issue has a tag assigned by te repo members, does that mean that it is planned to be implemented and I can open a pr? How does it work?

@Huilensolis This is a good question and maybe has 2 answers:

To choose issues you would like to work on:

Anything labelled as good-first-issue or help-wanted are the best ones to start with

To see if Supabase is working on it:

This one is more difficult and is not immediately visible. Maybe the easiest way is to check if the issue has a PR open against it.

@encima encima added the help wanted Extra attention is needed label Apr 28, 2024
@bl-aire
Copy link

bl-aire commented Apr 29, 2024

Hello @encima @Huilensolis ,

Please I need your help. I was able to setup a local instance of supabase using the instructions in the DEVELOPER.md but I can't create a table.

image

@encima
Copy link
Contributor

encima commented Apr 29, 2024

@bl-aire

we can help sure! But this is about a different issue, please open a new issue explaining the steps you followed, the versions you are running, the issue you are facing and any logs/errors that you experience.

@bl-aire
Copy link

bl-aire commented Apr 29, 2024

@bl-aire

we can help sure! But this is about a different issue, please open a new issue explaining the steps you followed, the versions you are running, the issue you are facing and any logs/errors that you experience.

Thank you!!
I'll do that now. Kinda new so I'm trying to understand supabase and its repository.

With time, I'll get a hang of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to improving accessibility bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants