Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space at end of column name. #76

Closed
GaryAustin1 opened this issue May 11, 2024 · 5 comments
Closed

Space at end of column name. #76

GaryAustin1 opened this issue May 11, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@GaryAustin1
Copy link

It is still a common occurrence users get a space at the end of a column name. This is extremely hard to spot in the UI and in the table definition it generates as there are not "" around the names.
Example:
https://github.com/orgs/supabase/discussions/26023

Might be good to flag column names with a space at the end as I cannot think of a good use case for that.

@GaryAustin1 GaryAustin1 added the bug Something isn't working label May 11, 2024
@olirice
Copy link
Collaborator

olirice commented May 13, 2024

thanks

I've added some metadata collection to the data eng pipeline to check how many instance of these exist. If its a common problem (more than 100 unique projects) we'll add it

I'll follow up nlt Wednesday once that data has been collected

@GaryAustin1
Copy link
Author

GaryAustin1 commented May 13, 2024

Turns out the latest OP was running an older version of the CLI with a studio that did not have the trimming in it.

@olirice
Copy link
Collaborator

olirice commented May 13, 2024

in that case, should we close this? or is it still worth scanning to see if anyone else is impacted?

@GaryAustin1
Copy link
Author

GaryAustin1 commented May 13, 2024

I would scan. Not sure what other ways it could get in there and the dashboard table UI does not really show trailing spaces.

When it happens it takes a lot of time to figure it out as everything looks correct.

@olirice
Copy link
Collaborator

olirice commented May 15, 2024

We currently have 0 impacted projects in the hosted environment so I'm going to close this for now.
lmk if you see another one come by

@olirice olirice closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants